[pbs-devel] applied: [PATCH v3 proxmox-backup] client: catalog shell: avoid navigating below archive root

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 12 21:09:09 CET 2024


Am 03.09.24 um 14:39 schrieb Christian Ebner:
> Avoid to underflow the catalogs shell position stack by navigating
> below the archives root directory into the catalog root. Otherwise
> the shell will panic, as the root entry is always expected to be
> present.
> 
> This threats the archive root directory as being it's own parent
> directory, mimicking the behaviour of most common shells.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> Encountered while implementing the catalog shell for the split pxar
> archive case.
> 
> Without this additional check, underflowing the pxar archive root of
> the catalog shell will panic.
> 
> changes since version 2, thanks @Wolfgang for catching this:
> - also handle cases where the current working directory is not the root
>   directory
> 
> changes since version 1:
> - use `is_empty` to check if vector is empty
> - extend commit message and comment to clarify that archive root acts as
>   its own parent directory
> 
>  pbs-client/src/catalog_shell.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!




More information about the pbs-devel mailing list