[pbs-devel] applied-series: [PATCH proxmox-backup v6 1/2] fix #5439: allow to reuse existing datastore

[Thomas Lamprecht]

Am 29.08.24 um 14:58 schrieb Gabriel Goller:
> Disallow creating datastores in non-empty directories. Allow adding
> existing datastores via a 'reuse-datastore' checkmark. This only checks
> if all the necessary directories (.chunks + subdirectories and .lock)
> exist and have the correct permissions. Note that the reuse-datastore
> path does not open the datastore, so that we don't drop the
> ProcessLocker of an existing datastore.
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> v6, thanks @Wolfgang
>  - iterate over directories with loop
>  - make `chunk_dir_accessible` not pub
>  - remove unnecessary clone
> 
> v5, thanks @Wolfgang:
>  - remove unnecessary call to `chunk_dir_accessible`
>  - match on exact permissions
>  - remove unused worker reference
> 
> v4, thanks @Thomas:
>  - move reuse-datastore checkbox to "advanced options"
> 
> v3, thanks @Fabian:
>  - don't open chunkstore on existing datastore, as this drops the
>    previous ProcessLocker
>  - factor out `ChunkStore::open` checks and call them in reuse-datastore
>    path as well
> 
> v2, thanks @Fabian:
>  - also check on frontend for root
>  - forbid datastore creation if dir not empty
>  - add reuse-datastore option
>  - verify chunkstore directories permissions and owners
> 
>  pbs-datastore/src/chunk_store.rs | 73 ++++++++++++++++++++++++++++----
>  src/api2/config/datastore.rs     | 45 +++++++++++++++-----
>  src/api2/node/disks/directory.rs |  4 +-
>  src/api2/node/disks/zfs.rs       |  4 +-
>  4 files changed, 105 insertions(+), 21 deletions(-)
> 
>

applied series, thanks!