[pbs-devel] applied: [pve-devel] [PATCH widget-toolkit v3 07/14] notification: add UI for adding/updating webhook targets

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Nov 10 18:27:09 CET 2024


Am 08.11.24 um 15:41 schrieb Lukas Wagner:
> The widgets for editing the headers/secrets were adapted from
> the 'Tag Edit' dialog from PVE's datacenter options.
> 
> Apart from that, the new dialog is rather standard. I've decided
> to put the http method and url in a single row, mostly to
> save space and also to make it analogous to how an actual http request
> is structured (VERB URL, followed by headers, followed by the body).
> 
> The secrets are a mechanism to store tokens/passwords in the
> protected notification config. Secrets are accessible via
> templating in the URL, headers and body via {{ secrets.NAME }}.
> Secrets can only be set/updated, but not retrieved/displayed.
> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> Tested-By: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
>  src/Makefile                  |   1 +
>  src/Schema.js                 |   5 +
>  src/Utils.js                  |  20 ++
>  src/panel/WebhookEditPanel.js | 424 ++++++++++++++++++++++++++++++++++
>  4 files changed, 450 insertions(+)
>  create mode 100644 src/panel/WebhookEditPanel.js
> 
>

applied, thanks!




More information about the pbs-devel mailing list