[pbs-devel] [PATCH proxmox-backup 1/2] sync: pull: mention why last snapshot of previous sync is resynced

Christian Ebner c.ebner at proxmox.com
Mon Nov 4 13:56:13 CET 2024


The last snapshot synced during the previous sync job might not have
been fully completed just yet (e.g. backup log still missing,
verification still ongoing, ...).
Explicitley mention the reason and that the resync is therefore
intentional by a comment in the filter logic.

Suggested-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 1:
- no present in previous version

 src/server/pull.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/server/pull.rs b/src/server/pull.rs
index cc1427196..8d8461cb2 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -528,6 +528,8 @@ async fn pull_group(
         .enumerate()
         .filter(|&(pos, ref dir)| {
             source_snapshots.insert(dir.time);
+            // Note: Last sync times final snapshot might not have been completely
+            // done yet on the source side, keep it include for a resync.
             if last_sync_time > dir.time {
                 already_synced_skip_info.update(dir.time);
                 return false;
-- 
2.39.5





More information about the pbs-devel mailing list