[pbs-devel] [PATCH v6 proxmox-backup 42/65] client: streams: add channels for dynamic entry injection

[Christian Ebner]

On 5/22/24 11:56, Dominik Csapak wrote:
> high level:
> 
> i think this patch would be much cleaner if the 57/65
> datastore:chunker: add Chunker trait
> 
> would come before this, because you change stuff around only to change 
> it again
> in a way that could be written better if those patches were
> 
> reversed, e.g.
> 
> in case there was a next_boundary in the ChunkStream, in the final code
> there is the same code from the regulary chunking duplicated
> 
> (this.buffer.split_to;this.consumed +=;this.scan_pos)
> 
> and could be trivially handled by the same code part
> (with a bit of reordering)
> 
> but the patches in this order make it hard to see since
> here the paths are different enough so they can't be shared

Okay, will see what to do about this.
The motivation for keeping the Chunker trait later in the series was 
(apart from it having been implemented as followup after being suggested 
by Fabian) that the dedicated payload chunker might not be 
accepted/applied, therefore rendering the trait useless. Therefore, I 
tried to decouple this a bit.