[pbs-devel] [PATCH v6 proxmox-backup 22/65] client: restore: read payload from dedicated index

Christian Ebner c.ebner at proxmox.com
Fri May 24 08:45:56 CEST 2024


On 5/21/24 14:44, Dominik Csapak wrote:
> this patch (and the next few) introduce a few checks that check the 
> filename
> for '.mpxar.didx' or '.mpxar' etc.
> 
> wouldn't it be nicer to have a helper that checks that at one point in 
> the code
> instead of sprinkling the extension strings around the code?
> e.g. a typo at any one of those places is easy to miss but might introduce
> bugs or unintended behavior

Agreed, moved this check into a helper function and use that whenever 
possible for the filename extension checks.





More information about the pbs-devel mailing list