[pbs-devel] [PATCH v6 proxmox-backup 30/65] file restore: factor out getting pxar reader

[Christian Ebner]

On 5/21/24 15:19, Dominik Csapak wrote:
> On 5/14/24 12:33, Christian Ebner wrote:
>> Factor out the logic to get the pxar reader into a dedicated function
>> so it can be reused to get the payload data archive reader instance.
>>
>> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
>> ---
>>   proxmox-file-restore/src/main.rs | 44 ++++++++++++++++++++------------
>>   1 file changed, 28 insertions(+), 16 deletions(-)
>>
>> diff --git a/proxmox-file-restore/src/main.rs 
>> b/proxmox-file-restore/src/main.rs
>> index 685ce34d9..8a11cff65 100644
>> --- a/proxmox-file-restore/src/main.rs
>> +++ b/proxmox-file-restore/src/main.rs
>> @@ -34,7 +34,7 @@ use pbs_client::{BackupReader, BackupRepository, 
>> RemoteChunkReader};
>>   use pbs_datastore::catalog::{ArchiveEntry, CatalogReader, 
>> DirEntryAttribute};
>>   use pbs_datastore::dynamic_index::{BufferedDynamicReader, 
>> LocalDynamicReadAt};
>>   use pbs_datastore::index::IndexFile;
>> -use pbs_datastore::CATALOG_NAME;
>> +use pbs_datastore::{BackupManifest, CATALOG_NAME};
>>   use pbs_key_config::decrypt_key;
>>   use pbs_tools::crypt_config::CryptConfig;
>> @@ -335,6 +335,31 @@ async fn list(
>>       Ok(())
>>   }
>> +async fn get_local_pxar_reader(
> 
> nit: this probably shouldn't be named 'get_local_pxar_reader' since none 
> of it is 'local' ?
> 
> also this has now the same name as the function used in the datastore 
> api to download
> files from pxar (locally)
> 
> probably 'get_remote_pxar_reader' ?

Agreed, seems like I got primed by the `LocalDynamicReadAt`... Will be 
called `get_remote_pxar_reader` in the upcoming version of the patches.