[pbs-devel] [RFC backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login

Gabriel Goller g.goller at proxmox.com
Thu May 16 18:24:57 CEST 2024


This has been requested many times already for all products. To keep 
it simple as it's still quite a niche feature, works with a single file:
/etc/proxmox-backup/consent.txt. If the file exists and is not empty, 
a consent banner will be shown in front of the login view.

This is just a reference implementation for pbs to get some feedback
and check if my general approach is alright. The same implementation 
will then be ported to pve and eventually pmg.

Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is 
probably off. I also have my doubts about the behavior when the user 
clicks "I decline", maybe we should completely exit the page?.

widget-toolkit:

Gabriel Goller (3):
  api: add consent api handler and config
  ui: show consent banner before login
  docs: add short section about consent banner

 docs/gui.rst               |  7 +++++++
 src/api2/access/consent.rs | 25 +++++++++++++++++++++++++
 src/api2/access/mod.rs     |  2 ++
 src/config/consent.rs      | 11 +++++++++++
 src/config/mod.rs          |  1 +
 www/LoginView.js           | 14 ++++++++++++++
 6 files changed, 60 insertions(+)
 create mode 100644 src/api2/access/consent.rs
 create mode 100644 src/config/consent.rs


backup:

Gabriel Goller (1):
  window: add consent modal

 src/Makefile               |  1 +
 src/window/ConsentModal.js | 39 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 src/window/ConsentModal.js


Summary over all repositories:
  8 files changed, 100 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.5.0




More information about the pbs-devel mailing list