[pbs-devel] [PATCH proxmox-backup] fix #5422: ui: make columns in gcview sortable

[Max Carrara]

On Tue May 7, 2024 at 10:13 AM CEST, Gabriel Goller wrote:
> These columns were not sortable for some reason. Tested it as well and
> the sorting seems to work fine.
>
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>

LGTM

Reviewed-by: Max Carrara <m.carrara at proxmox.com>
Tested-by: Max Carrara <m.carrara at proxmox.com>
> ---
>  www/config/GCView.js | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/www/config/GCView.js b/www/config/GCView.js
> index bcea72a5..1c9288e4 100644
> --- a/www/config/GCView.js
> +++ b/www/config/GCView.js
> @@ -164,7 +164,7 @@ Ext.define('PBS.config.GCJobView', {
>  	{
>  	    header: gettext('Schedule'),
>  	    dataIndex: 'schedule',
> -	    sortable: false,
> +	    sortable: true,
>  	    hideable: false,
>  	    renderer: (value) => value ? value : Proxmox.Utils.NoneText,
>  	    minWidth: 85,
> @@ -182,7 +182,7 @@ Ext.define('PBS.config.GCJobView', {
>  	    text: gettext('Duration'),
>  	    dataIndex: 'duration',
>  	    renderer: Proxmox.Utils.render_duration,
> -	    sortable: false,
> +	    sortable: true,
>  	    minWidth: 80,
>  	    flex: 1,
>  	},
> @@ -207,7 +207,7 @@ Ext.define('PBS.config.GCJobView', {
>  	    dataIndex: 'removed-bytes',
>  	    renderer: (value, meta, record) => record.data.upid !== null
>  		? Proxmox.Utils.format_size(value, true) : "-",
> -	    sortable: false,
> +	    sortable: true,
>  	    minWidth: 85,
>  	    flex: 1,
>  	},
> @@ -216,7 +216,7 @@ Ext.define('PBS.config.GCJobView', {
>  	    dataIndex: 'pending-bytes',
>  	    renderer: (value, meta, record) => record.data.upid !== null
>  		? Proxmox.Utils.format_size(value, true) : "-",
> -	    sortable: false,
> +	    sortable: true,
>  	    minWidth: 80,
>  	    flex: 3,
>  	},