[pbs-devel] [PATCH proxmox-backup v3] datastore: remove datastore from internal cache based on maintenance mode

Gabriel Goller g.goller at proxmox.com
Fri Mar 22 14:52:41 CET 2024


On Mon Mar 4, 2024 at 2:26 PM CET, Hannes Laimer wrote:
> We keep a DataStore cache, so ChunkStore's and lock files are kept by
> the proxy process and don't have to be reopened every time. However, for
> specific maintenance modes, e.g. 'offline', our process should not keep
> file in that datastore open. This clears the cache entry of a datastore
> if it is in a specific maintanance mode and the last task finished, which
> also drops any files still open by the process.
>
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>

The code looks good and clippy/fmt doesn't throw any errors!
Also tested this thoroughly and it works perfectly.

Consider:
Reviewed-by: Gabriel Goller <g.goller at proxmox.com>
Tested-by: Gabriel Goller <g.goller at proxmox.com>




More information about the pbs-devel mailing list