[pbs-devel] [RFC v2 proxmox-backup 33/36] client: pxar: add look-ahead caching

[Christian Ebner]

On 3/12/24 15:08, Fabian Grünbichler wrote:
> this is only called if we have a previous payload
> 
>> +        &mut self,
>> +        encoder: &mut Encoder<'_, T>,
>> +        accessor: &mut Option<Directory<LocalDynamicReadAt<RemoteChunkReader>>>,
> so this must always be set for the call to make any sense, so we can
> drop the Option<>.

That will not work, as this recursively also calls the 
`add_entry_to_archive` in case when to flush entries which requires the 
optional previous metadata accessor as it calls the `add_directory`, 
which requires this to make sure the accessor is following along the 
path the archiver walks.

I will however see if refactoring according to your other suggestions 
improves this.