[pbs-devel] [RFC v2 proxmox-backup 29/36] client: pxar: add previous reference to archiver

[Fabian Grünbichler]

> Christian Ebner <c.ebner at proxmox.com> hat am 19.03.2024 13:59 CET geschrieben:
> 
>  
> On 3/12/24 13:12, Fabian Grünbichler wrote:
> > this reader should be started after the writer (else somebody else might
> > be -however unlikely- faster and the reader is no longer for the
> > previous snapshot).
> > 
> > upside - it can then be moved into the download_previous_manifest arm,
> > if the previous manifest was not downloadable using the writer, or the
> > key changed, or something else -> we can already skip re-using it based
> > on those facts.
> The reason this is placed her (very inconveniently I know) is that the 
> HttpClient is consumed by the BackupWriter instance, and I have to reuse
> the same client (as otherwise I get locking issues).
> 
> Open for further discussion if there is a better way to handle this, I 
> also would like to move this to the match arm for pxar backup creation 
> if possible.

BackupWriter::start could also take a reference to the HttpClient? it does exactly the same things with it after all ;) maybe I am missing something..