[pbs-devel] [RFC v2 proxmox-backup 25/36] upload stream: impl reused chunk injector

Christian Ebner c.ebner at proxmox.com
Thu Mar 14 15:03:41 CET 2024


On 3/13/24 10:43, Dietmar Maurer wrote:
>  From a high level Perspective, this looks a
> bit too complicated. Cant we simply drop the current chunker
> when  we want to force a chunk-boundary, and start a new one
> after the injected chunks later?

Looking at this in more detail I am not sure what exactly would
be the benefit of dropping the chunker instance, since the
boundary has to be found in the byte stream buffer anyways
and since we do not actually know the BytesMut for the
reused chunks to be returned by the poll, the queues to
pass the ReusableDynamicEntries and the boundary where in
the BackupWriter upload stream they are required nevertheless
(see also patch 26 for the chunking itself).




More information about the pbs-devel mailing list