[pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls
Dominik Csapak
d.csapak at proxmox.com
Thu Mar 14 08:59:46 CET 2024
hi,
just to note: changing to an async function can be rather dangerous,
sometimes extjs not only calls the handlers/events/etc. but does things
after them (expecting the function to be finished) or waits for the return value.
(most of the extjs code was from before async/await was a thing in js)
so here it seems to work out fine, but we have to be careful with
sprinkling async function in the code, otherwise we'll get
very unexpected results
in general, i'd like to see that mentioned in the commit message
why it's ok to do that (no hard feelings though)
otherwise LGTM
More information about the pbs-devel
mailing list