[pbs-devel] [RFC pxar 06/36] encoder: move to stack based state tracking
Dietmar Maurer
dietmar at proxmox.com
Tue Mar 12 11:12:51 CET 2024
Seems the check for self.finished is now missing?
Sure, we have not done anything, but we should.
> -impl<'a, T: SeqWrite + 'a> Drop for EncoderImpl<'a, T> {
> - fn drop(&mut self) {
> - if let Some(ref mut parent) = self.parent {
> - // propagate errors:
> - parent.merge_error(self.state.encode_error);
> - if !self.finished {
> - parent.add_error(EncodeError::IncompleteDirectory);
> - }
> - } else if !self.finished {
> - // FIXME: how do we deal with this?
> - // eprintln!("Encoder dropped without finishing!");
> - }
> - }
> -}
More information about the pbs-devel
mailing list