[pbs-devel] [RFC v2 proxmox-backup 14/36] client: backup: split payload to dedicated stream

[Christian Ebner]

> On 11.03.2024 15:57 CET Fabian Grünbichler <f.gruenbichler at proxmox.com> wrote:
> 
> this parameter position is a bit arbitrary - and the later additions in
> this series don't really make it better.. maybe we could use this as an
> opportunity for some house keeping, thinking about what should go into
> the `options`, and whether some of the rest could be meaningfully
> grouped?
> 

Yes, will do that, I noticed that also `cargo clippy` is not happy with
this.

> > +
> > +        let backup_stream_payload = payload_rx.map(|rx| Self {
> 
> nit: IMHO this is a `backup_payload_stream` (a stream of payload(s)),
> not a `backup_stream_payload` (the payload of a backup stream)
> 

stems from simply postfixing all the duplicate instances for the split
archive case. But agreed, it is better called `backup_payload_stream`.

> 
> *bikeshed mode on* - .pld is rather opaque from a user's perspective,
> maybe .data would be a more human readable counterpart to .meta ?
> 

Dietmar mentioned off list that he is not happy with the postfix to
the .pxar archive file name, so we might introduce a dedicated file
ending for these kind of archives (as only the metadata archive even
follows the pxar file format, the payload archive is just a
concatenation of payloads which will be separated by the payload
header with the next version of the patch series for consistency
checks).