[pbs-devel] [RFC v2 proxmox-backup 13/36] client: backup: early check for fixed index type

Christian Ebner c.ebner at proxmox.com
Mon Mar 11 16:12:57 CET 2024


> On 11.03.2024 15:57 CET Fabian Grünbichler <f.gruenbichler at proxmox.com> wrote:
> >      let pxar_stream = PxarBackupStream::open(dir_path.as_ref(), catalog, pxar_create_options)?;
> >      let mut chunk_stream = ChunkStream::new(pxar_stream, chunk_size);
> > +    if upload_options.fixed_size.is_some() {
> > +        bail!("cannot backup directory with fixed chunk size!");
> > +    }
> 
> nit: while we're at it - why not do it first thing here before creating
> the streams? it does happen piece by piece later in the series, but
> could just happen here already.

Oops, true, seems I incorrectly placed this while rebasing the patch
series. Will move it to the top of the function call, so the patch
actually does what it was intended for.




More information about the pbs-devel mailing list