[pbs-devel] [RFC v2 pxar 09/36] encoder: add payload advance capability

[Christian Ebner]

> On 11.03.2024 14:22 CET Fabian Grünbichler <f.gruenbichler at proxmox.com> wrote:
> 
> 
> so isn't this in fact a PayloadOffset then (like it is returned as in
> the corresponding getter)? and isn't the size then actually another
> offset as well? would maybe make it easier to avoid "holding it wrong"
> (i.e., passing in some other u64), or at least, force to wrap it in
> PayloadOffset which hopefully entails double-checking that that makes
> sense ;)
> 

No, this is actually the size to advance the position of the payload stream by
when injecting reused chunks, so the caller will pass the total size of the
injected chunks.

I was thinking of adding the chunks themself as parameters, this would however
require to expose that type to the pxar crate, so I opted for keeping this as
unsigned integer. Maybe I should construct a dedicated type just for this?