[pbs-devel] applied-series: [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job

[Thomas Lamprecht]

Am 06/03/2024 um 15:11 schrieb Christian Ebner:
> Adds a global summary of the transferred chunk size and count, as well
> as the average transfer rate of a sync job to it's task log.
> 
> Patch 1/3 introduces a PullStats object, used to return the relevant
> data from each pull related method call.
> 
> Patch 2/3 adds the summary log line to the tasklog.
> 
> Patch 3/3 finally adapts the current log output to use the
> functionality of `HumanByte` to produce consistent output.
> 
> Tested by creating a local sync job and syncing a datastore, checking
> the output in the tasklog.
> Chunk counts where compared to `find .chunks -type f -print | wc -l`.
> 
> Bugtracker link:
> https://bugzilla.proxmox.com/show_bug.cgi?id=5285
> 
> Christian Ebner (3):
>   server: sync: return `PullStats` for pull related methods
>   fix #5285: api: sync: add job summary to task log
>   server: sync: use HumanByte for task log output
> 
>  src/api2/pull.rs   |  12 ++++-
>  src/server/pull.rs | 130 ++++++++++++++++++++++++++++++---------------
>  2 files changed, 99 insertions(+), 43 deletions(-)
> 

applied series with Max's R-b & T-b, thanks!

Albeit for such things it would be nice to add an example (excerpt) of the
new message/format in the commit message – I amended the respective commit
with that.

I also found a glitch for the case where no new data was pulled, as then
one got the following log entry:

> Summary: sync job pulled 0 B in 0 chunks (average rate: NaN B/s)

I made a follow-up commit that makes the API log a different messages
in that case.

Something that might be still relevant is mentioning the amount of
deleted (vanished) backups/groups in the summary.