[pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive

Gabriel Goller g.goller at proxmox.com
Wed Mar 6 15:34:10 CET 2024


To better debug the creation of the pxar archive, we encode the 
creation_params (the parameters passed to the cli) inside the pxar
archive. Like this we just need to locate the `.pxar_creation_params`
file in the archive and we can check which arguments have been used. 

To realize this, we unify all the parameters of the `create_backup`
function so that we don't need an additional struct (which in turn
introduces additional maintenance efforts).

An example `.pxar_creation_params` file would look like this:

    {
      "backupspec": [
        "test.pxar:linux"
      ],
      "chunk-size": 4096,
      "exclude": [
        "MAINTAINERS"
      ],
      "skip-e2big-xattr": true
    }


Some background: 
The original idea came from Dietmar and while it is surely useful, I
don't really like my implementation (most likely this is a skill-issue
from my side). So suggestions/critique of any kind is welcome!  

proxmox-backup:

Gabriel Goller (3):
  pxar: factor out encode_file
  client: unify parameters and write to file
  pxar: added creation parameters

 pbs-client/src/pxar/create.rs                 | 23 ++++++-
 pbs-client/src/pxar_backup_stream.rs          |  5 +-
 proxmox-backup-client/src/main.rs             | 29 +++++---
 .../src/proxmox_restore_daemon/api.rs         |  2 +-
 pxar-bin/Cargo.toml                           |  1 +
 pxar-bin/src/main.rs                          | 67 ++++++++++++-------
 tests/catar.rs                                |  1 +
 7 files changed, 89 insertions(+), 39 deletions(-)


Summary over all repositories:
  7 files changed, 89 insertions(+), 39 deletions(-)

-- 
Generated by git-murpp 0.5.0




More information about the pbs-devel mailing list