[pbs-devel] [PATCH widget-toolkit/proxmox-backup] adapt to stricter api parameter checks

Dominik Csapak d.csapak at proxmox.com
Wed Mar 6 12:20:57 CET 2024


since a bit, i believe commit
bae2cf75 (schema: AllOf/OneOf: actually perform additional_properties() check)

in proxmox-schema, sending additional properties not defined for an api
call is forbidden and leads to an error.

Sadly, the gui did not adhere strictly to the api definition and
sometimes sent more data that what was defined, now resulting in various
api errors when using the gui.

This series fixes those that i found (there are probably some that i
missed).

I did not include the whole detail why in every commit, but if that's
preferred just holler and i add a sentence or two to every commmit.

the first patch in proxmox-backup is just indentation cleanup and not
really related, so could be applied independently.

proxmox-widget-toolkit:

Dominik Csapak (1):
  realms: don't send type and delete on creation

 src/window/AuthEditLDAP.js   |  8 ++++----
 src/window/AuthEditOpenId.js | 10 ----------
 2 files changed, 4 insertions(+), 14 deletions(-)

proxmox-backup:

Dominik Csapak (6):
  ui: prune job edit: indent fix
  ui: metrics: don't send digest when creating a new influxdbupd host
  ui: tape backup job: don't send delete value on creation
  ui: prune: fix sending invalid parameters
  ui: sync job: don't send delete value on creation
  ui: verify job: don't send delete value on creation

 www/datastore/Content.js         |  1 +
 www/panel/PrunePanel.js          |  2 +-
 www/tape/window/TapeBackupJob.js | 14 ++++++++++++++
 www/window/InfluxDbEdit.js       | 20 +++++++++++---------
 www/window/PruneJobEdit.js       | 11 ++++++++---
 www/window/SyncJobEdit.js        | 14 +++++++++++++-
 www/window/VerifyJobEdit.js      |  4 +++-
 7 files changed, 51 insertions(+), 15 deletions(-)

-- 
2.39.2





More information about the pbs-devel mailing list