[pbs-devel] [PATCH widget-toolkit 1/1] realms: don't send type and delete on creation

Dominik Csapak d.csapak at proxmox.com
Wed Mar 6 12:20:58 CET 2024


those are not valid properties for pbs, which is currently the only user
of these panels/windows.

Sending these parameters will result in the api call failing.

When we want to reuse these panels for other products, we'll have to
make them a bit more flexible/generic anyway.

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 src/window/AuthEditLDAP.js   |  8 ++++----
 src/window/AuthEditOpenId.js | 10 ----------
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index eb9700a..0494d3f 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -32,10 +32,6 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
     onlineHelp: 'user-realms-ldap',
 
     onGetValues: function(values) {
-	if (this.isCreate) {
-	    values.type = this.type;
-	}
-
 	if (values.anonymous_search) {
 	    if (!values.delete) {
 		values.delete = [];
@@ -51,6 +47,10 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
 	    values.delete.push("password");
 	}
 
+	if (this.isCreate) {
+	    delete values.delete;
+	}
+
 	delete values.anonymous_search;
 
 	return values;
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index ca84958..b9648f7 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -5,16 +5,6 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
 
     type: 'openid',
 
-    onGetValues: function(values) {
-	let me = this;
-
-	if (me.isCreate) {
-	    values.type = me.type;
-	}
-
-	return values;
-    },
-
     columnT: [
 	{
 	    xtype: 'textfield',
-- 
2.39.2





More information about the pbs-devel mailing list