[pbs-devel] [RFC v2 pxar 10/36] encoder/format: finish payload stream with marker

Christian Ebner c.ebner at proxmox.com
Tue Mar 5 10:26:37 CET 2024


Mark the end of the optional payload stream, this makes sure that at
least some bytes are written to the stream (as empty archives are not
allowed by the proxmox backup server) and possible injected chunks
must be consumed.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 1:
- no changes

 examples/mk-format-hashes.rs | 5 +++++
 src/encoder/mod.rs           | 7 +++++++
 src/format/mod.rs            | 2 ++
 3 files changed, 14 insertions(+)

diff --git a/examples/mk-format-hashes.rs b/examples/mk-format-hashes.rs
index 83adb38..de73df0 100644
--- a/examples/mk-format-hashes.rs
+++ b/examples/mk-format-hashes.rs
@@ -56,6 +56,11 @@ const CONSTANTS: &[(&str, &str, &str)] = &[
         "PXAR_GOODBYE_TAIL_MARKER",
         "__PROXMOX_FORMAT_PXAR_GOODBYE_TAIL_MARKER__",
     ),
+    (
+        "The end marker used in the separate payload stream",
+        "PXAR_PAYLOAD_TAIL_MARKER",
+        "__PROXMOX_FORMAT_PXAR_PAYLOAD_TAIL_MARKER__",
+    ),
 ];
 
 fn main() {
diff --git a/src/encoder/mod.rs b/src/encoder/mod.rs
index c90a526..fdd5c8f 100644
--- a/src/encoder/mod.rs
+++ b/src/encoder/mod.rs
@@ -884,6 +884,13 @@ impl<'a, T: SeqWrite + 'a> EncoderImpl<'a, T> {
 
         if let EncoderOutput::Owned(output) = &mut self.payload_output {
             if let Some(output) = output {
+                seq_write_pxar_entry(
+                    output,
+                    format::PXAR_PAYLOAD_TAIL_MARKER,
+                    &[],
+                    &mut state.payload_write_position,
+                )
+                .await?;
                 flush(output).await?;
             }
         }
diff --git a/src/format/mod.rs b/src/format/mod.rs
index a3a7245..999308d 100644
--- a/src/format/mod.rs
+++ b/src/format/mod.rs
@@ -105,6 +105,8 @@ pub const PXAR_PAYLOAD_REF: u64 = 0x419d3d6bc4ba977e;
 pub const PXAR_GOODBYE: u64 = 0x2fec4fa642d5731d;
 /// The end marker used in the GOODBYE object
 pub const PXAR_GOODBYE_TAIL_MARKER: u64 = 0xef5eed5b753e1555;
+/// The end marker used in the separate payload stream
+pub const PXAR_PAYLOAD_TAIL_MARKER: u64 = 0x6c72b78b984c81b5;
 
 #[derive(Debug, Endian)]
 #[repr(C)]
-- 
2.39.2





More information about the pbs-devel mailing list