[pbs-devel] applied: Re: [PATCH widget-toolkit 1/1] dns: optionally send delete for optional values

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Mar 1 12:43:12 CET 2024


On 01/03/2024 10:03, Dominik Csapak wrote:
> pbs only deletes the optional values here when they are sent with the
> 'delete' parameter, in contrast to pve/pmg that don't have a delete
> parameter currently and always use the parameters as source of truth.
> 
> So to handle that, optionally set deleteEmpty if set from outside
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/node/DNSEdit.js | 6 ++++++
>  src/node/DNSView.js | 4 ++++
>  2 files changed, 10 insertions(+)
> 
>

applied, with a follow up for the comment to avoid coupling this to a
specific downstream dependency, that just will get outdated and has not
much use on its own anyway here, thanks!




More information about the pbs-devel mailing list