[pbs-devel] [PATCH proxmox-rrd] cache: skip non-utf8 lines in rrd journal

Lukas Wagner l.wagner at proxmox.com
Fri Jun 28 14:25:18 CEST 2024



On  2024-06-28 14:20, Christian Ebner wrote:
>> On 28.06.2024 14:09 CEST Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
>> Do we even have anything non-ASCII in that file?
>> I'd think the file got corrupted some other way.
>> So would we really want to apply it? Perhaps just let the admin
>> clear/remove it?
> 
> No, the file should per se be valid UTF-8, even ASCII only.
> I already replied to the user to clean up the file to solve the issue, fine by me if this is discarded.
> 

The journal is applied on daemon startup and every 30 mins - so it should be fine
to just discard it, one loses only up to 30mins of metric data - which doesn't
sound so bad for a rare data corruption like this.

-- 
- Lukas




More information about the pbs-devel mailing list