[pbs-devel] [PATCH proxmox-backup] http_client: keep renewal future running on failed re-auth

[Hannes Laimer]

The re-authentication request can also fail due to network instability,
and not necesarrily only due to an invalid ticket. In that case it makes
sense to retry refreshing the ticket in 15 minutes. Also, the future does
not depend on a failed re-authentication to be clean up properly, so that
happens already somewhere else, therefore we don't rely on this return
anyway. If the ticket is actually invalid or timed out, the main job
will fail and also terminate the renewal future, same applies if the
network is not just unstable but straight up not working.

Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
---
 pbs-client/src/http_client.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs
index 27e6ab5d..8ae5edaa 100644
--- a/pbs-client/src/http_client.rs
+++ b/pbs-client/src/http_client.rs
@@ -469,7 +469,6 @@ impl HttpClient {
                     }
                     Err(err) => {
                         log::error!("re-authentication failed: {}", err);
-                        return;
                     }
                 }
             }
-- 
2.39.2