[pbs-devel] applied-series: [PATCH proxmox{, -backup} v7 0/2] close #4763: client: add command to forget backup group

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Jun 19 11:37:35 CEST 2024


applied this but replaced the `extract_repository_from_value` call with
a newly added `remove_repository_from_value` call since this code
actually passed the `--repository` parameter on to the remote side,
which does not accept unknown parameters anymore

On Mon, Jun 03, 2024 at 10:43:09AM GMT, Gabriel Goller wrote:
> Add the command `proxmox-backup-client group forget <group>` so
> that we can forget (delete) whole groups with all the containing
> snapshots. As this is quite dangerous, we added a prompt, so the
> user has to confirm the operation.
> 
> v7, thanks @Wolfgang:
>  - style nit: return unit type on success in api fn
>  - let `Confirmation` impl Clone, Copy, and Eq as well
>  - with Copy we can let the fn's consume self
>  - organize imports
> 
> v6, thanks @Thomas:
>  - add more generic confirmation helper drawn up by @Thomas
>  - stricter yes/no matching with default
> 
> v5, thanks @Christian:
>  - stricter input matching ($ in regex)
>  - avoid printing full datastore path
> 
> v4:
>  - removed localization
> 
> --version 3 has been skipped--
> 
> v2:
>  - added localization
> 
> proxmox:
> 
> Gabriel Goller (1):
>   router: cli: add confirmation helper
> 
>  proxmox-router/Cargo.toml     |   1 +
>  proxmox-router/src/cli/mod.rs | 114 +++++++++++++++++++++++++++++++++-
>  2 files changed, 114 insertions(+), 1 deletion(-)
> 
> 
> proxmox-backup:
> 
> Gabriel Goller (1):
>   close #4763: client: add command to forget backup group
> 
>  proxmox-backup-client/src/group.rs | 88 ++++++++++++++++++++++++++++++
>  proxmox-backup-client/src/main.rs  |  3 +
>  2 files changed, 91 insertions(+)
>  create mode 100644 proxmox-backup-client/src/group.rs
> 
> 
> Summary over all repositories:
>   4 files changed, 205 insertions(+), 1 deletions(-)
> 
> -- 
> Generated by git-murpp 0.5.0




More information about the pbs-devel mailing list