[pbs-devel] partially-applied: [PATCH v3 pxar proxmox-backp 0/6] fix fuse mount performance for split archives

[Fabian Grünbichler]

applied pxar patches 1, 2 and 4, and added some feedback on 3 that
affects the rest

On June 12, 2024 10:23 am, Christian Ebner wrote:
> Fuse mounts for split pxar archives currently greatly suffer from the
> consistency check between metadata and payload data archives, as
> these happen already during decoding of the payload reference entry
> in the metadata archive. By moving this check to the content reader
> instantiation, the performance can be improved significantly, as now
> the payload data chunks only need to be fetched and decoded when
> actually accessing the file payloads.
> 
> Changes since version 2:
> - Make helper and ContentRange pub(crate) only
> - Fix typo in commit message
> - Move incorrectly squashed cargo fmt patch into own patch
> 
> Changes since version 1:
> - Add previously missing check when accessing contents via the accessor
>   instead of the decoder.
> - Add missing context and refactor file entry extraction branch in pxar
>   extract according to suggestions
> 
> pxar:
> 
> Christian Ebner (5):
>   accessor: fix minor formatting issue
>   format: add helper for payload header consistency checks
>   format: add helper type ContentRange
>   decoder: move payload header check for split input
>   accessor: add payload checks for split archives
> 
>  src/accessor/aio.rs  | 15 ++++++-----
>  src/accessor/mod.rs  | 60 +++++++++++++++++++++++++++++++++-----------
>  src/accessor/sync.rs | 16 ++++++------
>  src/decoder/aio.rs   |  4 +--
>  src/decoder/mod.rs   | 56 +++++++++++++++++++++++------------------
>  src/decoder/sync.rs  |  5 ++--
>  src/format/mod.rs    | 32 +++++++++++++++++++++++
>  7 files changed, 132 insertions(+), 56 deletions(-)
> 
> promxox-backup:
> 
> Christian Ebner (1):
>   client: pxar: fix fuse mount performance for split archives
> 
>  pbs-client/src/pxar/extract.rs | 62 ++++++++++++++++------------------
>  pbs-pxar-fuse/src/lib.rs       | 14 ++++----
>  src/api2/tape/restore.rs       |  2 +-
>  3 files changed, 37 insertions(+), 41 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>