[pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login

[Gabriel Goller]

On 06.06.2024 15:04, Thomas Lamprecht wrote:
>Am 06/06/2024 um 14:09 schrieb Dominik Csapak:
>>> I don't have any strong opinions though, so I'll let you decide... 🙂
>>> If we do it, we should maybe rename the option to consent_test_base64 or
>>> something, so that it's instantly visible that it's encoded?
>> yeah the name should probably reflect that, @thomas any opinion regarding
>> base64 ?
>
>We normally do not include the format in the property names, but it still
>_might_ be OK to add it there.
>Otherwise, the description can mention it and a validator should catch actual
>invalid base64 though, as any space is invalid it would be quite obvious to
>admins when the test how it looks.
>
>Alternatively (just as idea, not as recommendation) you could make it rather
>obvious by requiring a format, or encoding, like:
>
>ui_consent: format=base64,value=...
>
>or possibly already with the type in there:
>
>consent: type=ui,format=base64,value=...

Hmm, idk, for me this looks like there are different formats and types
available—which we don't plan to add anytime soon.