[pbs-devel] applied: [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Jun 6 10:54:54 CEST 2024


thanks!

On June 6, 2024 10:17 am, Christian Ebner wrote:
> When running as user with uid/gid not equal to 1000/1000, the test to
> create a pxar archive with previous metadata reference would fail, as
> the created test directories and files do not get the expected ownership
> set because of lack of permissions.
> 
> Therefore these patches do:
> - not even attempt to set the uid/gid for the folders, as without
>   permissions these are not set anyways.
> - only execute the test on the condition that euid and egid are 1000
> 
> Tested by running the tests via:
> `cargo test --workspace --release -- --nocapture`
> 
> For root user and user with uid/gid 1000. Without the patches the test
> fails for the root user, with the patches applied it passes for both.
> 
> Christian Ebner (2):
>   client: pxar: do not attempt to set uid/gid in test
>   client: pxar: conditionally skip metadata reference test
> 
>  pbs-client/src/pxar/create.rs | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 




More information about the pbs-devel mailing list