[pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login
Gabriel Goller
g.goller at proxmox.com
Tue Jun 4 14:50:03 CEST 2024
The consent text is stored in the node.cfg config file and is encoded
using encodeURI [0] on the frontend. This allows us to support multi-line
strings and special characters. To easily edit the text a new edit-field
called ProxmoxTextAreaField has been introduced. It supports editing and
saving multi-line text and converting it to its URI-encoded representation.
The same implementation will be ported to pve and eventually pmg in
the foreseeable future.
v2, thanks @Thomas, @Dominik:
- remove consent.txt file, move to node.cfg config
- add ui option to insert consent text
- encode text with encodeURI/decodeURI
v1, thanks @Dominik:
- embed consent text into index.html file instead of extra api request
- removed decline button
- added alwaysOnTop property to popup
[0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI
widget-toolkit:
Gabriel Goller (2):
window: add consent modal
form: add support for multiline textarea
src/Makefile | 2 ++
src/form/TextAreaField.js | 60 ++++++++++++++++++++++++++++++++++++++
src/grid/ObjectGrid.js | 29 ++++++++++++++++++
src/window/ConsentModal.js | 34 +++++++++++++++++++++
4 files changed, 125 insertions(+)
create mode 100644 src/form/TextAreaField.js
create mode 100644 src/window/ConsentModal.js
backup:
Gabriel Goller (3):
api: add consent api handler and config option
ui: show consent banner before login
docs: add section about consent banner
docs/gui.rst | 7 +++++++
src/api2/node/config.rs | 8 ++++++++
src/bin/proxmox-backup-proxy.rs | 11 ++++++++---
src/config/node.rs | 4 ++++
www/LoginView.js | 9 +++++++++
www/config/NodeOptionView.js | 6 ++++++
www/index.hbs | 1 +
7 files changed, 43 insertions(+), 3 deletions(-)
Summary over all repositories:
11 files changed, 168 insertions(+), 3 deletions(-)
--
Generated by git-murpp 0.5.0
More information about the pbs-devel
mailing list