[pbs-devel] [PATCH v8 proxmox-backup 35/69] pxar: cover listing for split archives

[Christian Ebner]

On 6/3/24 15:27, Fabian Grünbichler wrote:
> On May 28, 2024 11:42 am, Christian Ebner wrote:
>> Allows to list entries of split pxar archives. As the decoder skips
>> over the file payloads, the corresponding payload file has to be
>> provided. Otherwise the decoder would skip inside the metadata
>> archive, leading to incorrect decoding.
>>
>> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
>> ---
>> changes since version 7:
>> - no changes
>>
>> changes since version 6:
>> - not present in previous version
>>
>>   pxar-bin/src/main.rs | 18 ++++++++++++++++--
>>   1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs
>> index 903467c98..b64ae1d19 100644
>> --- a/pxar-bin/src/main.rs
>> +++ b/pxar-bin/src/main.rs
>> @@ -454,12 +454,26 @@ async fn mount_archive(archive: String, mountpoint: String, verbose: bool) -> Re
>>               archive: {
>>                   description: "Archive name.",
>>               },
>> +            "payload-input": {
>> +                description: "'ppxar' payload input data file for split archive.",
>> +                optional: true,
>> +            },
> 
> nit: this one is also missing completion
> 
> and I guess mount is missing split support entirely?
> 
> technically, we could also add it for the create part (without caching
> logic of course)..
> 

Yes, both of these are not present because split archives were/are 
intended for the PBS side only. But slowly supporting these on the pxar 
side as well seems to creep in I guess (usecase being mostly 
debugging?)... So I should add both as well I guess?