[pbs-devel] [PATCH proxmox] rest-server: Encode with zlib headers

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 18 18:08:07 CEST 2024


Am 17/07/2024 um 17:49 schrieb Max Carrara:
> On Tue Jul 16, 2024 at 11:22 AM CEST, Maximiliano Sandoval wrote:
>> As per [RFC9110] the Deflate encoding is a "zlib" data format. This
>> makes the rest-server compatible with the http-client.
>>
>> [RFC9110] https://www.rfc-editor.org/rfc/rfc9110#field.content-encoding
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
>> ---
>>
>> By default the builder will use the default compression level. Please let me
>> know if the Level::Default should be set explicitly.
> 
> This patch looks simple enough to me and does what it says on the tin;
> I can't really spot anything wrong here.

Does the "does what it says on the tin" part also mean you tested this
explicitly? Just wondering why no T-b was given and how closely I need
to check this out ;-)




More information about the pbs-devel mailing list