[pbs-devel] [PATCH proxmox-backup] api: list-snapshots improvements

[Gabriel Goller]

On 03.07.2024 15:46, Christian Ebner wrote:
>Hi, some initial high level comments, did not test this just yet.
>
>You touch several completely unrelated thing in this patch. I feel that this should be split into at least 3-4 patches:

Sure, I can do that. I just didn't want to pollute the mailing list with
a bunch of one-line fixes :)

>- fixing the typo
>- removing the unsafe block (although this feels like Wolfgang did this on purpose to make a caller aware of possible consequences, see commit message for a577d7d8).
>- avoid double retrial of protected flag, (can we also assure that this is not done on purpose, to avoid possible races?)
>- refactor of `full_path`
>
>Also, can you see a noticeable difference in listing time for groups with a larger number of backups?
>Please give some ballpark figures if so.

Hmm yeah, I can write some benchmarks quickly, shouldn't be a lot
though, some 100-200 ms maybe.