[pbs-devel] [PATCH proxmox-backup] api: make prune-group a real workertask

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jan 24 14:28:54 CET 2024


Am 24/01/2024 um 14:17 schrieb Fiona Ebner:
> Am 24.01.24 um 11:34 schrieb Gabriel Goller:
>> -    Ok(json!(prune_result))
> 
>> +    Ok(json!(upid))
> 
> That seems like a breaking API change at a first glance and thus has to
> wait for the next major release unfortunately.
> 
> AFAIU the same rules as for PVE apply, see:
> https://pve.proxmox.com/wiki/Proxmox_VE_API#API_Stability_.26_Breakage
> 

Yes, if applied strictly, and this here might be indeed a breakage that
matters in practice.

But you can work around that by making it use a worker task opt-in via
a new parameter boolean flag.

Oh, and isn't prune_result now unused? We're still lacking a simple 
and standardized method to save a structured result alongside a task
UPID, otherwise it could be saved there, but that's another topic.




More information about the pbs-devel mailing list