[pbs-devel] [PATCH widget-toolkit/proxmox-backup 00/10] Fix #3115: VLAN Network Interface Configuration

[Lukas Wagner]

On 1/11/24 16:52, Stefan Lendl wrote:
> This patch series allows configuration of VLAN network interfaces in the PBS GUI
> 
> * Adds reading and writing of vlan network interface configs from network/interfaces
> * Creating and updating of VLAN network interfaces via the API
> * Copy the VlanId widget from PVE and enable the Linux VLAN interface type in the GUI
> * Unit tests
> * Some cleanup to leave touched functions cleaner than before
> 

Gave these changes a try. Mostly works fine, however there is a small 
bug that prohibits updating existing non-VLAN devices - see other 
replies for details.

I liked how approached testing for these changes, e.g. by adding tests 
for the existing code first to make sure that your following changes do 
not break anything. That's always a good idea!

-- 
- Lukas