[pbs-devel] applied: [PATCH proxmox-backup 0/5] improve duplicate label-text handling

Dietmar Maurer dietmar at proxmox.com
Fri Jan 12 10:27:48 CET 2024


applied

On 1/11/24 11:40, Dominik Csapak wrote:
> while most of the code assumes each label is unique in the inventory,
> there is actually no safeguard against doing that.
>
> this can lead to confusion about which tape is
> inserted/online/destroyed/vaulted/etc.
>
> so this series tries to improve the handling a bit by logging a warning
> when encountering this, and also preventing new tapes being labeled with
> an existing label
>
> also add the 'destroy' media function to the ui, so that users
> can get more easily out of this situation
>
> Dominik Csapak (5):
>    tape: handle duplicate label-texts in inventory
>    api: tape: optinally accept uuid for destroy/move media
>    api: tape: don't allow duplicate media label-texts
>    ui: tape inventory: use uuid as id
>    ui: tape: add remove media button
>
>   src/api2/tape/drive.rs                | 79 +++++++++++++++++--------
>   src/api2/tape/media.rs                | 84 ++++++++++++++++++++++-----
>   src/tape/changer/online_status_map.rs | 26 +++++----
>   src/tape/inventory.rs                 | 26 ++++++---
>   www/Makefile                          |  1 +
>   www/tape/TapeInventory.js             | 35 ++++++++++-
>   www/tape/window/MediaRemoveWindow.js  | 66 +++++++++++++++++++++
>   7 files changed, 257 insertions(+), 60 deletions(-)
>   create mode 100644 www/tape/window/MediaRemoveWindow.js
>




More information about the pbs-devel mailing list