[pbs-devel] [PATCH proxmox 2/6] remove needless_borrow

Maximiliano Sandoval m.sandoval at proxmox.com
Wed Feb 28 12:39:16 CET 2024


Fixes the clippy lint

    warning: this expression creates a reference which is immediately dereferenced by the compiler
       --> proxmox-api-macro/src/util.rs:868:25
        |
    868 |     duplicate(&*target, &path);
        |                         ^^^^^ help: change this to: `path`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
        = note: `#[warn(clippy::needless_borrow)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 proxmox-api-macro/src/util.rs          | 2 +-
 proxmox-rest-server/src/worker_task.rs | 2 +-
 proxmox-schema/src/de/no_schema.rs     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxmox-api-macro/src/util.rs b/proxmox-api-macro/src/util.rs
index 324c460d..428b1e4d 100644
--- a/proxmox-api-macro/src/util.rs
+++ b/proxmox-api-macro/src/util.rs
@@ -865,7 +865,7 @@ pub fn parse_str_value_to_option<T: Parse>(
     path: &syn::Path,
     nv: syn::parse::ParseStream<'_>,
 ) {
-    duplicate(&*target, &path);
+    duplicate(&*target, path);
     match nv.parse().and_then(|lit| parse_lit_str(&lit)) {
         Ok(value) => *target = Some(value),
         Err(err) => crate::add_error(err),
diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
index 4cf24cc4..5bab4cdc 100644
--- a/proxmox-rest-server/src/worker_task.rs
+++ b/proxmox-rest-server/src/worker_task.rs
@@ -850,7 +850,7 @@ impl WorkerTask {
             file_opts: setup.file_opts.clone(),
             ..Default::default()
         };
-        let logger = FileLogger::new(&path, logger_options)?;
+        let logger = FileLogger::new(path, logger_options)?;
 
         let worker = Arc::new(Self {
             setup,
diff --git a/proxmox-schema/src/de/no_schema.rs b/proxmox-schema/src/de/no_schema.rs
index 546e5001..45fe08cd 100644
--- a/proxmox-schema/src/de/no_schema.rs
+++ b/proxmox-schema/src/de/no_schema.rs
@@ -303,7 +303,7 @@ impl<'a> Iterator for SplitList<'a> {
     type Item = &'a str;
 
     fn next(&mut self) -> Option<&'a str> {
-        let range = super::next_str_entry(&self.input, &mut self.at, self.has_null)?;
+        let range = super::next_str_entry(self.input, &mut self.at, self.has_null)?;
         Some(&self.input[range])
     }
 }
-- 
2.39.2





More information about the pbs-devel mailing list