[pbs-devel] [PATCH proxmox] subscription: Use const rather than static

Wed Feb 28 10:54:56 CET 2024

A static is like a const that can mutate, we don't need that.

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 proxmox-rest-server/src/formatter.rs          | 2 +-
 proxmox-subscription/src/subscription_info.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-rest-server/src/formatter.rs b/proxmox-rest-server/src/formatter.rs
index d19d6805..b9ed3bce 100644
--- a/proxmox-rest-server/src/formatter.rs
+++ b/proxmox-rest-server/src/formatter.rs
@@ -41,7 +41,7 @@ pub trait OutputFormatter: Send + Sync {
     }
 }
 
-static JSON_CONTENT_TYPE: &str = "application/json;charset=UTF-8";
+const JSON_CONTENT_TYPE: &str = "application/json;charset=UTF-8";
 
 fn json_data_response(data: Value) -> Response<Body> {
     let json_str = data.to_string();
diff --git a/proxmox-subscription/src/subscription_info.rs b/proxmox-subscription/src/subscription_info.rs
index ae40dbff..c2e3e7ea 100644
--- a/proxmox-subscription/src/subscription_info.rs
+++ b/proxmox-subscription/src/subscription_info.rs
@@ -302,7 +302,7 @@ pub(crate) fn md5sum(data: &[u8]) -> Result<DigestBytes, Error> {
 
 /// Generate the current system's "server ID".
 pub fn get_hardware_address() -> Result<String, Error> {
-    static FILENAME: &str = "/etc/ssh/ssh_host_rsa_key.pub";
+    const FILENAME: &str = "/etc/ssh/ssh_host_rsa_key.pub";
 
     let contents = proxmox_sys::fs::file_get_contents(FILENAME)
         .map_err(|e| format_err!("Error getting host key - {}", e))?;
-- 
2.39.2



