[pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view.

Stefan Lendl git at stfl.dev
Wed Feb 21 10:56:31 CET 2024


From: Stefan Lendl <s.lendl at proxmox.com>

Fix #3217: Addition of a new tab "Prune & GC" in "Datastore" and not in each Datastore created
Fix #4723: add last, next run, status, duration to gc

Extends the garbage collection view to display in addition to the schedule:
 - State (of last run)
 - Duration (of last run)
 - Last Run Date
 - Next Run Date (if scheduled)
 - Removed Chunks (in last run)
 - Pending Chunks (as of last run)

In the Datastore global overview, the prune view is extended to show the same
details for all availible datastores also the ones without a gc-schedule.

Allows editing the schedule, showing the log of the last run and manually
running the gc job.  In the global view, by selecting the row of the datastore.

Adds a proxmox-backup-manager cli command to list all gc jobs
`proxmox-backup-manager garbage-collection list`


Changes v2 -> v3:
 - fixed indentation (how hard can it be?..)
 - added git trailers

Changes v1 -> v2:
 - sort imports
 - fix eslint warnings
 - update columns in GC Job view to fill the entire width
 - not include path PruneJobEdit (sent separatly)

This is based on a series from g.goller
Changes to g.goller's series:
 - rename endpoint from gc-info to gc-job-status
 - add list-all-gc-jobs endpoint
 - UI uses Grid (table) view instead of model grid
 - implement GC job view in global view

Stefan Lendl (8):
  api: garbage collect job status
  gc: global prune and gc job view
  gc: move datastore/PruneAndGC to config/PruneAndGC
  gc: hide datastore column in local gc view
  ui: order Prune&GC before SyncJobs
  cli: list gc jobs with proxmox-backup-manager
  gc: show removed and pending chunks of last run in ui
  gc: configure width and flex on GC Jobs columns

 pbs-api-types/src/datastore.rs    |  40 +++++
 src/api2/admin/datastore.rs       | 129 +++++++++++++++-
 src/api2/admin/gc.rs              |  57 +++++++
 src/api2/admin/mod.rs             |   2 +
 src/bin/proxmox-backup-manager.rs |  33 ++++
 www/Makefile                      |   4 +-
 www/Utils.js                      |   6 +-
 www/config/GCView.js              | 243 ++++++++++++++++++++++++++++++
 www/config/PruneAndGC.js          |  52 +++++++
 www/datastore/DataStoreList.js    |  11 +-
 www/datastore/Panel.js            |   3 +-
 www/datastore/PruneAndGC.js       | 133 ----------------
 www/window/GCJobEdit.js           |  28 ++++
 13 files changed, 593 insertions(+), 148 deletions(-)
 create mode 100644 src/api2/admin/gc.rs
 create mode 100644 www/config/GCView.js
 create mode 100644 www/config/PruneAndGC.js
 delete mode 100644 www/datastore/PruneAndGC.js
 create mode 100644 www/window/GCJobEdit.js

-- 
2.43.0





More information about the pbs-devel mailing list