[pbs-devel] partially-applied: [PATCH backup 1/4] disks: remove useless conversion to the same type

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Feb 13 11:30:48 CET 2024


applied 1 and 3, comments for 2 and 4 sent as well..

On February 13, 2024 10:53 am, Maximiliano Sandoval wrote:
> Fixes the clippy lint:
> 
> ```
> warning: useless conversion to the same type: `std::ffi::OsString`
>     --> src/tools/disks/mod.rs:1161:9
>      |
> 1161 |         count_str.into(),
>      |         ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `count_str`
>      |
>      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> ```
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
> This patch series contains the missing patches from my "last" clippy patch series.
> 
>  src/tools/disks/mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs
> index 78360b66..94f89e0a 100644
> --- a/src/tools/disks/mod.rs
> +++ b/src/tools/disks/mod.rs
> @@ -1158,7 +1158,7 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc<WorkerTask>) -> Result<(), Error>
>          of_path,
>          "bs=1M".into(),
>          "conv=fdatasync".into(),
> -        count_str.into(),
> +        count_str,
>      ];
>      dd_command.args(args);
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 




More information about the pbs-devel mailing list