[pbs-devel] [PATCH backup v3] fix-3699: pbs-client/tools: use xdg basedirectories for tmp files

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Feb 12 10:46:53 CET 2024


Thomas Lamprecht <t.lamprecht at proxmox.com> writes:

>> +pub fn create_tmp_file() -> std::io::Result<std::fs::File> {
>
> Hmm, wondering if "create_xdg_tmp_file" could be slightly better here,
> but the fallback behavior is not the best fit with that name, so no
> hard feelings from my side.

Since this indeed can create files outside of XDG_CACHE_HOME I opted for
not putting `xdg` in the fn name. It is also a bit more future-proof in
case the function is refactored/modified. No strong opinions anyways.

I will send a v4 today.

--
Maximiliano




More information about the pbs-devel mailing list