[pbs-devel] applied: [PATCH proxmox-backup v2] fix #5190: api-types: openid acr format regex

[Thomas Lamprecht]

Am 06/02/2024 um 11:09 schrieb Gabriel Goller:
> Allow more complex strings for the acr-value when using openid. The
> openid documentation only specifies the acr-value *should* be an URI [0].
> Implemented a regex that loosely disallows some of the reserved URI
> characters specified in the RFC [1].
> 
> Currently values like:
> - "urn:mace:incommon:iap:silver"
> - "urn:comsolve.nl:idp:contract:rba:location"
> do NOT work, although they are correct URI's and common acr tokens.
> 
> [0]: https://openid.net/specs/openid-connect-core-1_0.html
> [1]: https://www.rfc-editor.org/rfc/rfc2396.txt
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> v1 -> v2 changes:
>  * added more context, renamed variable
> 
>  pbs-api-types/src/lib.rs    | 5 +++++
>  pbs-api-types/src/openid.rs | 7 ++++---
>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
>

applied, reflowed the commit message to fit in < 70 characters per
line, as per our dev docs [0], and added a reference to the PVE
change (can only help), thanks!

[0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages