[pbs-devel] [PATCH proxmox-backup 3/8] prune: use NoneText as emptyValue in PruneJobEdit

Gabriel Goller g.goller at proxmox.com
Mon Feb 5 14:50:36 CET 2024


On Mon Feb 5, 2024 at 12:58 PM CET, Stefan Lendl wrote:
> Display None value as presented in Proxmox.Utils.NoneText.
> Make this identical to other uses where a None value is displayed
>
> Signed-off-by: Stefan Lendl <s.lendl at proxmox.com>
> ---
>  www/window/PruneJobEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
> index 84159a9d..fa4fc149 100644
> --- a/www/window/PruneJobEdit.js
> +++ b/www/window/PruneJobEdit.js
> @@ -114,7 +114,7 @@ Ext.define('PBS.window.PruneJobEdit', {
>  		fieldLabel: gettext('Prune Schedule'),
>  		xtype: 'pbsCalendarEvent',
>  		name: 'schedule',
> -		emptyText: gettext('none (disabled)'),
> +		emptyText: gettext(Proxmox.Utils.NoneText + " (disabled)"),
>  		cbind: {
>  			deleteEmpty: '{!isCreate}',
>  			value: '{scheduleValue}',

Hmm, the schedule value here is not optional, so adding `(disabled)` is
kind of misleading... I think it's better to remove `emptyText` and add
a `allowBlank: false` here.




More information about the pbs-devel mailing list