[pbs-devel] applied: [PATCH proxmox-backup] api: move DataStoreConfig parsing and mount check after allowed check

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 16 13:42:00 CET 2024


Am 16.12.24 um 12:50 schrieb Shannon Sterz:
> this moves the parsing of the concrete DataStoreConfig as well as the
> check whether a store is mounted after the authorization checks.
> otherwise we always check for all datastore whether they are mounted,
> even if the requesting user has no privileges to list the specified
> datastore anyway.
> 
> this may improve performance for large setups, as we won't need to stat
> mounted datastores regardless of the useres privileges. this was
> suggested on the mailing list [1].
> 
> [1]: https://lore.proxmox.com/pbs-devel/embeb48874-d400-4e69-ae0f-2cc56a39d592@93f95f61.com/
> 
> Signed-off-by: Shannon Sterz <s.sterz at proxmox.com>
> ---
>  src/api2/admin/datastore.rs | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
>

applied, thanks!




More information about the pbs-devel mailing list