[pbs-devel] applied: [PATCH proxmox-backup] pxar: client: fix missing file size check for metadata comparison

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 9 13:00:41 CET 2024


Am 08.12.24 um 20:34 schrieb Christian Ebner:
> Change detection mode set to metadata compares regular file entries
> metadata to the reference metadata archive of the previous run. The
> `pxar::format::Stat` as stored in `pxar::Metadata` however does not
> include the actual file size, it only partially stores information
> gathered from stating the file.
> 
> This means however that the actual file size is never compared and
> therefore, that if the file size did change, but the other metadata
> information did not (including the mtime which might have been
> restored), that file will be incorrectly reused.
> A subsequent restore will however fail, because the expected file size
> as encoded in the metadata archive does not match the file size as
> stored in the payload archive.
> 
> Fix this by adding the missing file size check, comparing the size
> for the given file against the one stored in the metadata archive.
> 
> Link to issue reported in community forum:
> https://forum.proxmox.com/threads/158722/
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
>  pbs-client/src/pxar/create.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




More information about the pbs-devel mailing list