[pbs-devel] applied: [PATCH v2 proxmox-backup 1/3] client: backup: remove unnecessary clone for backup reader

[Fabian Grünbichler]

this one already, thanks!

On December 4, 2024 9:31 am, Christian Ebner wrote:
> This was introduced by commit fdea4e53 ("client: implement prepare
> reference method") to read a reference metadata archive for detection
> of unchanged, reusable files when using change detection mode set to
> `metadata`.
> 
> Avoid unnecessary cloning of the atomic reference counted
> `BackupReader` instance, as it is used exclusively for this codepath.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 1:
> - fix incorrect commit title by s/writer/reader/
> 
>  proxmox-backup-client/src/main.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
> index 9daa513f9..632a29170 100644
> --- a/proxmox-backup-client/src/main.rs
> +++ b/proxmox-backup-client/src/main.rs
> @@ -1107,7 +1107,7 @@ async fn create_backup(
>                                  &target,
>                                  manifest.clone(),
>                                  &client,
> -                                backup_reader.clone(),
> +                                backup_reader,
>                                  crypt_config.clone(),
>                                  crypto.mode,
>                              )
> @@ -1310,7 +1310,7 @@ async fn prepare_reference(
>      let most_used = metadata_ref_index.find_most_used_chunks(8);
>      let file_info = manifest.lookup_file_info(&target)?;
>      let chunk_reader = RemoteChunkReader::new(
> -        backup_reader.clone(),
> +        backup_reader,
>          crypt_config.clone(),
>          file_info.chunk_crypt_mode(),
>          most_used,
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>