[pbs-devel] [PATCH v2 proxmox-backup 0/3] handle reader client disconnects
    Christian Ebner 
    c.ebner at proxmox.com
       
    Wed Dec  4 09:31:46 CET 2024
    
    
  
These patches attempt to improve the server side error handling for
reader client disconnects.
During regular operation, the server currently cannot distinguish a
disconnect because of error from a disconnect because of finished
operation. This leaves behind a task in failed state, which is
unexpected and might cause confusion [0].
To improve error handling, follow the approach taken for the backup
writer tasks, letting the client signal it has successfully finished
via an api call and catch the disconnect error for that case.
Reported in the community forum:
[0] https://forum.proxmox.com/threads/158306/
Version 1 of the patches:
https://lore.proxmox.com/pbs-devel/20241203112756.63872-1-c.ebner@proxmox.com/T/
Christian Ebner (3):
  client: backup: remove unnecessary clone for backup reader
  api: reader: handle reader client disconnects
  client: reader: signal server before client disconnect
 pbs-client/src/backup_reader.rs   |  2 ++
 proxmox-backup-client/src/main.rs |  4 ++--
 src/api2/reader/environment.rs    | 20 +++++++++++++++++++-
 src/api2/reader/mod.rs            | 30 +++++++++++++++++++++++++++---
 4 files changed, 50 insertions(+), 6 deletions(-)
-- 
2.39.5
    
    
More information about the pbs-devel
mailing list