[pbs-devel] [PATCH proxmox-backup 3/3] client: reader: signal server before client disconnect

Christian Ebner c.ebner at proxmox.com
Tue Dec 3 12:27:56 CET 2024


Signal the server that the client has successfully finished its
operation and is about to close the connection. This allows the server
side to react and clean up the connection gracefully, without
returning and logging an error state, as that can cause confusion [0],
as this is not an error but normal behaviour.

Report in the community forum:
[0] https://forum.proxmox.com/threads/158306/

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
 pbs-client/src/backup_reader.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pbs-client/src/backup_reader.rs b/pbs-client/src/backup_reader.rs
index 88cba599b..63106c999 100644
--- a/pbs-client/src/backup_reader.rs
+++ b/pbs-client/src/backup_reader.rs
@@ -27,6 +27,8 @@ pub struct BackupReader {
 
 impl Drop for BackupReader {
     fn drop(&mut self) {
+        // Ignore errors
+        let _ = proxmox_async::runtime::block_on(self.post("finish", None));
         self.abort.abort();
     }
 }
-- 
2.39.5





More information about the pbs-devel mailing list