[pbs-devel] [PATCH proxmox 07/10] remove unnecessary return statement
Maximiliano Sandoval
m.sandoval at proxmox.com
Tue Dec 3 11:20:35 CET 2024
Fixes the clippy lint:
```
warning: unneeded `return` statement
--> proxmox-time/src/week_days.rs:31:14
|
31 | _ => return Err(parse_error(text, "weekday")),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
31 | _ => Err(parse_error(text, "weekday")),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
proxmox-apt/src/repositories/file/sources_parser.rs | 2 +-
proxmox-time/src/week_days.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-apt/src/repositories/file/sources_parser.rs b/proxmox-apt/src/repositories/file/sources_parser.rs
index 6d1eeb34..c85b8d2e 100644
--- a/proxmox-apt/src/repositories/file/sources_parser.rs
+++ b/proxmox-apt/src/repositories/file/sources_parser.rs
@@ -43,7 +43,7 @@ impl<R: BufRead> APTSourcesFileParser<R> {
if key.starts_with('-') {
return false;
};
- return key.chars().all(|c| matches!(c, '!'..='9' | ';'..='~'));
+ key.chars().all(|c| matches!(c, '!'..='9' | ';'..='~'))
}
/// Try parsing a repository in stanza format from `lines`.
diff --git a/proxmox-time/src/week_days.rs b/proxmox-time/src/week_days.rs
index da446c5b..c409d292 100644
--- a/proxmox-time/src/week_days.rs
+++ b/proxmox-time/src/week_days.rs
@@ -28,7 +28,7 @@ fn parse_weekday(i: &str) -> IResult<&str, WeekDays> {
"friday" | "fri" => Ok((i, WeekDays::FRIDAY)),
"saturday" | "sat" => Ok((i, WeekDays::SATURDAY)),
"sunday" | "sun" => Ok((i, WeekDays::SUNDAY)),
- _ => return Err(parse_error(text, "weekday")),
+ _ => Err(parse_error(text, "weekday")),
}
}
--
2.39.5
More information about the pbs-devel
mailing list